]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
lookingGlass: Fix misleading typeof use
authorFlorian Müllner <fmuellner@gnome.org>
Mon, 19 Aug 2019 18:11:12 +0000 (20:11 +0200)
committerFlorian Müllner <florian.muellner@gmail.com>
Wed, 11 Sep 2019 20:59:31 +0000 (20:59 +0000)
typeof is an operator, not a function. Putting unneeded parentheses
around the expression obfuscates that.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/710

js/ui/lookingGlass.js

index 2c1239cd5f86de76da2f4359eca57432eba21e37..1143dedb52f15d0d488b1923992787db64182eee 100644 (file)
@@ -240,7 +240,7 @@ var Notebook = class Notebook {
 Signals.addSignalMethods(Notebook.prototype);
 
 function objectToString(o) {
-    if (typeof(o) == typeof(objectToString)) {
+    if (typeof o == typeof objectToString) {
         // special case this since the default is way, way too verbose
         return '<js function>';
     } else {
@@ -369,7 +369,7 @@ var ObjInspector = class ObjInspector {
 
         let hbox = new St.BoxLayout({ style_class: 'lg-obj-inspector-title' });
         this._container.add_actor(hbox);
-        let label = new St.Label({ text: 'Inspecting: %s: %s'.format(typeof(obj),
+        let label = new St.Label({ text: 'Inspecting: %s: %s'.format(typeof obj,
                                                                      objectToString(obj)) });
         label.single_line_mode = true;
         hbox.add(label, { expand: true, y_fill: false });
@@ -387,7 +387,7 @@ var ObjInspector = class ObjInspector {
         button.add_actor(new St.Icon({ icon_name: 'window-close-symbolic' }));
         button.connect('clicked', this.close.bind(this));
         hbox.add(button);
-        if (typeof(obj) == typeof({})) {
+        if (typeof obj == typeof {}) {
             let properties = [];
             for (let propName in obj) {
                 properties.push(propName);